Re: [PATCH] Honor sysconfdir when set as an configure option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kacper Kornet <kornet@xxxxxxxxxxx> writes:

> ./configure can be run with option --sysconfdir=...
> and Makefile should respect that choice.

Thanks.  That statement is not wrong per-se, but your patch will result in
git_etcdir always set to the same as $(sysconfdir) that is an absolute
path, which in turn would mean that the build product with prefix set to
something other than /usr won't relocate well, no?

Not that I personally deeply care about it, but I understand msysgit folks
spent considerable amount of brainpower to come up with the arrangement,
so they may want to have a say on this patch.

"git shortlog -n --no-merges --grep=msys --grep=Win -- Makefile" tells
me that Steffen Prohaska and J6t are the people to whom I need to Cc:
this.

>  ifeq ($(prefix),/usr)
> -sysconfdir = /etc
> -git_etcdir = /etc
> +sysconfdir ?= /etc
> +git_etcdir ?= /etc
>  else
> -sysconfdir = $(prefix)/etc
> -git_etcdir = etc
> +sysconfdir ?= $(prefix)/etc
> +git_etcdir ?= etc
>  endif
>  
>  ifdef CHECK_HEADER_DEPENDENCIES
> diff --git a/config.mak.in b/config.mak.in
> index e378534..ac5912d 100644
> --- a/config.mak.in
> +++ b/config.mak.in
> @@ -15,6 +15,8 @@ TCLTK_PATH = @TCLTK_PATH@
>  prefix = @prefix@
>  exec_prefix = @exec_prefix@
>  bindir = @bindir@
> +sysconfdir = @sysconfdir@
> +git_etcdir = @sysconfdir@
>  gitexecdir = @libexecdir@/git-core
>  datarootdir = @datarootdir@
>  template_dir = @datadir@/git-core/templates
> -- 
> 1.7.5
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]