Junio C Hamano <gitster@xxxxxxxxx> writes: > Johan Herland <johan@xxxxxxxxxxx> writes: > >>> Even better, probably they can be left to diff_opt_parse() without >>> calling this function, as you are deprecating them and do not have to >>> allow them to take the opt1,opt2,... form of parameter. >> >> I understand, but politely disagree: Patch 6/6 complicates the logic >> that DIFF_OPT_SET()/CLR() various bits in the diff options. I'd rather >> keep that logic in one place, than duplicate it into diff_opt_parse(). > > I've given a brief look at the v3. Looks better than the previous one; > not using double is especailly a big and good thing. Also, I had to rename the new test to t4047 to avoid crashing with an existing test when merged to 'pu'. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html