On Tuesday 26 April 2011, Junio C Hamano wrote: > Johan Herland <johan@xxxxxxxxxxx> writes: > > Allow specifying --dirstat cut-off percentage as a floating point > > number. > > > > When printing the dirstat output, floating point numbers are presented > > in rounded form (as opposed to truncated). > > Why isn't it sufficient to change > > permille = this_dir * 1000 / changed > > to > > permille = (this_dir * 2000 + changed) / (changed * 2) > > or something? If rounding is the only issue that bothers you (I admit > that it does bother me, now that you brought it up), that is. Actually, rounding doesn't bother me at all (or rather, I don't really care if we round or truncate, as long as we're consistent). It's just that once I s/strtoul/strtod/, and started propagating the "double"s through the code, I found that doing the final calculation and output with "double"s was more natural than the (somewhat hackish, IMHO) permille/percent thing. And that's when I finally came across the fact that "%6.1f" rounds whereas the earlier version truncated. I thought about it for a second, and figured that rounding was probably what most users expected. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html