Re: [PATCH] Refactor git-completion to allow ZSH usage of PS1 functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marius Storm-Olsen <mstormo@xxxxxxxxx> writes:

> Junio C Hamano said the following on 26.04.2011 12:21:
>> I'd be very negative on splitting this file into more than one files.
>
> The only other option would be duplication. Is that preferred?

That is not the answer I was hoping to hear.  Can't we think of a way to
share without duplication the common parts and have tweaks per two shell
implementations?

A conditional that says "Do this part only if I am zsh" in a single file
is fine.  Makefile that concatenates the common one and specific one among
two would also be acceptable, even though it makes things more cumbersome
to the user.  But no matter what you do, I would really prefer for the
user to have to copy just _one_ file, not two.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]