2011/4/26 Junio C Hamano <gitster@xxxxxxxxx>:
> Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx> writes:
>
>> strbuf_grow(sb, 0) may allocate less than requested len and violate the
>> next assertion.
>>
>> Signed-off-by: Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx>
>> ---
>> Âstrbuf.h | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/strbuf.h b/strbuf.h
>> index 07060ce..ab213da 100644
>> --- a/strbuf.h
>> +++ b/strbuf.h
>> @@ -34,7 +34,7 @@ extern void strbuf_grow(struct strbuf *, size_t);
>>
>> Âstatic inline void strbuf_setlen(struct strbuf *sb, size_t len) {
>> Â Â Â if (!sb->alloc)
>> - Â Â Â Â Â Â strbuf_grow(sb, 0);
>> + Â Â Â Â Â Â strbuf_grow(sb, len);
>> Â Â Â assert(len < sb->alloc);
>
> This looks so obviously correct that it is scary.
>
> How could 60 callsites of this function manage to have run without crashes
> so far? ÂThey all happen to use the function on a buffer that already has
> something on it?
I guess no current call site does _setlen right after initialization.
It's new code that triggers it.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html