Re: [PATCH 0/2] Documentation fixes for git-svn.txt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Valentin Haenel <valentin.haenel@xxxxxx> wrote:
> My remaining question regarding the second option, '--add-author-from',
> is about the subcommands which it is applicable to. The current
> documentation states 'commit' and 'dcommit'. My feeling is that 'commit'
> is a typo, since 'git svn' does not have a 'commit' subcommand. I had a
> look at the code, and while I am not familiar with perl, it seems to me
> that the three subcommands that use the option are 'commit-diff',
> 'set-tree' and 'dcommit'. But this is non-trivial -- feedback is
> appreciated.

Yes, commit-diff, set-tree, and dcommit all use --add-author-from.

I don't have time to build the docs and test formatting, but your
changes all look reasonable, consider them:

Acked-by: Eric Wong <normalperson@xxxxxxxx>

Thanks!

-- 
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]