On Tue, 2011-04-19 at 16:52 -0500, Jonathan Nieder wrote:
> Thiago Farina wrote:
> > when I run:
> > $ git send-email --to linux-kernel@xxxxxxxxxxxxxxx --cc-cmd
> > scripts/get_maintainer.pl foo
> > I'm getting some lines like:
> > Use of uninitialized value $cc in string eq at
> > /home/tfarina/libexec/git-core/git-send-email line 964.
> Yes, sounds like a bug. Cc-ing some send-email people for tips.
I haven't seen this.
What versions of ./scripts/get_maintainer.pl and git are
you using?
> On the other hand, using --cc-cmd=scripts/get_maintainer.pl does not
> sound like a great idea to me. On one hand the output of
> get_maintainer.pl is not an unadorned address per line like --cc-cmd
> expects. On the other hand, at least some versions of
> get_maintainer.pl returned more addresses than are likely to be
> interested people (by using --git by default).
>
> I think get_maintainer.pl is meant to be a starting point for tracking
> down who might be interested in a patch and should be followed by
> careful investigation. (That means making sure that there is a
> reasonable number of people and the reasons given by --roles ouput
> make sense, and maybe even glancing at some messages by them from the
> relevant mailing list to make sure the script has not gone haywire.)
Jonathan is basically correct in the what he writes above.
I also think git history isn't a very good mechanism to
rely on for determining MAINTAINERS, it should only be a
fallback to determine who should receive a copy of a patch.
That said, I use scripts/get_maintainer.pl to generate
to's and cc's. I do not use --git or --git-fallback
and rely only on the MAINTAINERS file pattern matching.
Here are the settings I use:
$ cat ~/.gitconfig
[sendemail]
chainreplyto = false
thread = false
suppresscc = self
tocmd = ~/bin/to.sh
cccmd = ~/bin/cc.sh
$ cat ~/bin/to.sh
#!/bin/bash
opts="--nogit --nogit-fallback --norolestats --pattern-depth=1"
if [[ $(basename $1) =~ ^0000- ]] ; then
./scripts/get_maintainer.pl --nom $opts $(dirname $1)/*
else
maint=$(./scripts/get_maintainer.pl --nol $opts $1)
if [ "$maint" == "" ] ; then
echo "linux-kernel@xxxxxxxxxxxxxxx"
else
echo "$maint"
fi
fi
$ cat ~/bin/cc.sh
#!/bin/bash
opts="--nogit --nogit-fallback --norolestats"
if [[ $(basename $1) =~ ^0000- ]] ; then
./scripts/get_maintainer.pl --nom $opts $(dirname $1)/*
else
./scripts/get_maintainer.pl $opts $1
fi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html