luke@xxxxxxxxxxx wrote on Tue, 19 Apr 2011 19:01 +0100:
> Patches from git passed into p4 end up with the committer
> being identified as the person who ran git-p4.
>
> With "submit --preserve-user", git-p4 sets P4USER. If the
> submitter has sufficient p4 permissions, the p4 equivalent
> of the git email committer will be passed into perforce.
I like the idea. Have often thought about using this approach
myself. Some comments:
1. Can we have a .git/config option too?
2. p4 users output is already cached; you should use
the same loadUserMapFromCache() and friends, or refactor
to share the cache.
3. Andrew will convert your tabs into spaces later, maybe save him
the effort now.
4. Do you need both "P4USER" and "User:" for this to work?
Perhaps just use the "User:" one if so, it is a bit more
concise.
5. Document how "p4 protect" is used to give admin privileges
needed for this to work, but won't tell you if you have them.
I think it may be true that "p4 typemap -o" needs admin
priviliges, and is a way to test if you ever need that.
6. What happens if you try, and don't have admin? Does it
silently just use you instead? And your comment about
"fixup later manually": I've always wondered how actually
to do that with p4, can you advise?
7. Super-bonus points for a test case in t/t9800-git-p4.sh. :)
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html