Thanks. The patch looks very sane, isolated to be safe enough,
and useful.
Except that this statement made me go "huh?" wondering what it
would do to the $filehandle to evaluate <$filehandle> in a void
context:
+ # Skip the empty line of the proxy server output
+ <$s>;
and I ended up looking in perlop.pod and came up empty.
The "I/O Operators" section talks about evaluating <$s> in a
scalar context (i.e. "$rep = <$s>"), which we all know would
return a single line, and in list context, which swallows
everything up to EOF, an obvious disaster for this particular
use. I couldn't find how it is defined to behave in a void
context. By experiments I know this returns only one line, but
it leaves me feeling somewhat uneasy.
Also it has a style inconsistency between "if(expression) {" and
"if(expression){", and I do not like either of them, but fixing
that should be left to a separate patch.
I'll apply this unless Martin or other people on the list who
have stake in cvsimport objects.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html