On Wed, Apr 13, 2011 at 8:16 PM, Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> wrote: > Nguyen Thai Ngoc Duy venit, vidit, dixit 13.04.2011 15:12: >> On Wed, Apr 13, 2011 at 8:05 PM, Michael J Gruber >> <git@xxxxxxxxxxxxxxxxxxxx> wrote: >>> - Â Â Â Â Â Â Â Â Â Â Â ret = run_command_v_opt(alias_argv, RUN_USING_SHELL); >>> + Â Â Â Â Â Â Â Â Â Â Â strbuf_addstr(&sb, "GIT_CWD="); >>> + Â Â Â Â Â Â Â Â Â Â Â if (subdir) >>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â strbuf_addstr(&sb, subdir); >>> + Â Â Â Â Â Â Â Â Â Â Â env[0] = sb.buf; >>> + Â Â Â Â Â Â Â Â Â Â Â env[1] = NULL; >>> + Â Â Â Â Â Â Â Â Â Â Â ret = run_command_v_opt_cd_env(alias_argv, RUN_USING_SHELL, NULL, env); >>> + Â Â Â Â Â Â Â Â Â Â Â strbuf_release(&sb); >>> Â Â Â Â Â Â Â Â Â Â Â Âif (ret >= 0) Â /* normal exit */ >>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âexit(ret); >> >> subdir can be NULL. I'm not sure if it can be empty string though. May > > I'm pretty sure that my "if (subdir)" would catch that... Yes. I skimmed too quick and realized after sending my email. >> need a check and set it to '.' so "cd $GIT_CWD" does not go back to >> $HOME. > > Well, with the current implementation you get empty or the subdir so > that you can easily "test -n $GIT_CWD". If you want to cd around you can > do "cd ./$GIT_CWD" unconditionally. I think this is more useful than > having a "." there. In that case should the variable have a another name? CWD/PWD is usually absolute path. "cd ./$GIT_CWD" looks odd to me. Or you can getcwd() and set $OLDPWD. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html