Re: REMOTE_USER value propagation through http push

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Axel <axel.ml@xxxxxxxxxxx> writes:

> I set up a git server with HTTP authentication with Apache through
> LDAP (Debian Squeeze + Apache 2.2 + mod_authnz_ldap).
> 
> I m using gitweb for browsing the repositories. At this moment, the
> commiter name appears to be the local user who called "git push". The
> username used for HTTP authentication is not used as commiter name,
> though the REMOTE_USER environment variable is defined.
> 
> After a quick look at http-backend.c it looks like the
> GIT_COMMITER_NAME variable should have been defined with the
> REMOTE_USER variable. Is this right ?
> 
> In Apache access logs, the REMOTE_USER appears to be defined in the
> last request of the push :
> 
> 127.0.1.1 - - [13/Apr/2011:11:45:08 +0200] "GET
> /git/sandbox/info/refs?service=git-receive-pack HTTP/1.1" 200 467 "-"
> "git/1.7.2.5"
> 127.0.1.1 - - [13/Apr/2011:11:45:08 +0200] "POST
> /git/sandbox/git-receive-pack HTTP/1.1" 401 618 "-" "git/1.7.2.5"
> 127.0.1.1 - ldapuser [13/Apr/2011:11:45:08 +0200] "POST
> /git/sandbox/git-receive-pack HTTP/1.1" 200 353 "-" "git/1.7.2.5"
> 
> Is this behaviour expected ?

I don't quite understand.

With push over _any_ transport you transfer commits from your
repository to remote repository *without changing them*.  Committer is
a person who created a commit, i.e. did "git commit" (or "git am", or
"git rebase", or "git merge").

The only place where user who did "git push" can appear in is _reflogs_
(I don't know if it appears or not)... but gitweb doesn't show wny
reflog information.  That of course can be improved...

-- 
Jakub Narebski
Poland
ShadeHawk on #git
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]