Re: [PATCH 4/3] --dirstat: In case of renames, use target filename instead of source filename

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 12, 2011 at 2:24 AM, Johan Herland <johan@xxxxxxxxxxx> wrote:
> This changes --dirstat analysis to count "damage" toward the target filename,
> rather than the source filename. For renames within a directory, this won't
> matter to the final output, but when moving files between diretories, the
> output now lists the target directory rather than the source directory.

Ack. I think the use of the source filename was actually a bug.

The original dirstat code used the "struct diffstat_file_t *" pointer,
and took the name from the ->name field of that. And that actually
defaults to the target name (see diffstat_add()). But then commit
c04a7155a03e changed it to use "struct dirstat_file" and picked the
name for that from the source.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]