Hi, I've started working on building a sequencer for Git. While the outline is described in [1], I'd like some additional clarifications. A big thanks to Christian's series [2] for the valuable roadmap. Please note that 10/11 is not related to this series, but seems to be a minor nit that's required to make all existing tests pass. 0. Is the general flow alright? 1. Is it okay to use this kind of adaptive error handling (calling 'die' in some places and returning error in other places), or should it be more uniform? 2. In 11/11, I've used cmd_revert and cmd_rerere. This is highly inelegant, mainly because of the command-line argument parsing overhead. Re-implementing it using more low-level functions doesn't seem to be the way to go either: for example, 'reset --hard' has some additional logic of writing HEAD and ORIG_HEAD, which I don't want to duplicate. Should I work on reworking parts of 'rerere.c' and 'revert.c', or is there some other way? 3. From the format of the TODO and DONE files, one more thing should be clear- I'm trying to stick to a slight variation of the 'rebase -i' format. This part will go into the sequencer. Then I'll use a cherry-pick specific file to keep the command-line options. Yes, I'm trying to work on Daniel's idea [3] from the very start. Is this a good idea? 4. I have a feeling that I've broken translation strings. Is there a README, plus a bunch of tests I can run to make sure that I've not broken anything? Thanks for reading. -- Ram [1]: http://thread.gmane.org/gmane.comp.version-control.git/170758/focus=170908 [2]: http://thread.gmane.org/gmane.comp.version-control.git/162183 [3]: http://thread.gmane.org/gmane.comp.version-control.git/170758/focus=170834 Ramkumar Ramachandra (11): revert: Avoid calling die; return error instead revert: Lose global variables "commit" and "me" revert: Introduce a struct to parse command-line options into revert: Separate cmdline argument handling from the functional code revert: Catch incompatible command-line options early revert: Implement parsing --continue, --abort and --skip revert: Handle conflict resolutions more elegantly usage: Introduce error_errno correspoding to die_errno revert: Write head, todo, done files revert: Give noop a default value while argument parsing revert: Implement --abort processing advice.c | 14 ++ advice.h | 1 + builtin/revert.c | 454 ++++++++++++++++++++++++++++++++++++++--------------- git-compat-util.h | 2 + usage.c | 34 ++++ 5 files changed, 381 insertions(+), 124 deletions(-) -- 1.7.4.rc1.7.g2cf08.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html