On Fri, Apr 8, 2011 at 00:10, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Hi, > > Ramsay Jones wrote: > >> +++ b/gettext.h >> @@ -35,6 +35,6 @@ const char *Q_(const char *msgid, const char *plu, unsigned long n) > [...] >> -#define N_(msgid) (msgid) >> +#define N_(msgid) msgid > > Good catch. ÂThanks! > >> In particular, standard C does not allow a parenthesized string >> as an array initializer. > > The subject line seems unnecessarily vague. ÂWhy not: > >    Âi18n: avoid parenthesized string as array initializer > >    ÂThe syntax > >        Âstatic const char ignore_error[] = ("something"); > >    Âis invalid C. ÂGCC and MSVC can parse it, but for example >    Âtcc cannot. ÂSo remove the parenthesis from the definition >    Âof the N_() macro. > >    ÂSigned-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> >    ÂAcked-by: Jonathan Nieder <jrnieder@xxxxxxxxx> This looks good to me with this commit message: Acked-by: Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html