2011/4/10 Junio C Hamano <gitster@xxxxxxxxx>:
>> +/*
>> + * Magic pathspec
>> + *
>> + * NEEDSWORK: These need to be moved to dir.h or even to a new
>> + * pathspec.h when we restructure get_pathspec() users to use the
>> + * "struct pathspec" interface.
>> + *
>> + * Possible future magic semantics include stuff like:
>> + *
>> + * Â { PATHSPEC_NOGLOB, '!', "noglob" },
>> + * Â { PATHSPEC_RECURSIVE, '*', "recursive" },
>> + * Â { PATHSPEC_REGEXP, '\0', "regexp" },
>> + *
>> + */
>
> Gaah, why did you butcher this to heve only the whole comment and struct
> type declaration here, without moving the "Possible future magic" comment
> that clearly belongs to the structure definition you still have in dir.c
> to where it belongs? ÂAlso if NOGLOB is no longer "Possible future", why
> is it still here?
Carelessness, I guess. Will move it (with the NOGLOB future line
removed) to dir.c, close to get_pathspec().
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html