Re: [tig PATCH] blame broken in recent master

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 09, 2011 at 02:37:38PM -0400, Jonas Fonseca wrote:

> On Wed, Mar 30, 2011 at 10:24, Jeff King <peff@xxxxxxxx> wrote:
> 
> > As of 730ae86 (Rename prepare_io to prepare_update and make it more
> > specialized, 2011-03-16), "tig blame" finds no actual blamed commits.
> >
> > The problem seems to be that prepare_update switched from calling
> > format_argv to argv_copy, and we end up calling "git blame %(blameargs)"
> > without "%(blameargs)" expanded. Blame looks like the only caller which
> > actually uses a placeholder, so it is the only one broken.
> >
> > The patch below fixes it for me, but it seems like a hack. I'm not
> > really sure why the switch in prepare_update was made; clearly it is
> > part of some refactoring, but I'm not sure what your larger plans were.
> 
> I have fixed the issue in the current master.

Thanks, works perfectly here.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]