Re: [PATCH 2/4] add -u: get rid of "treewideupdate" configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 9, 2011 at 6:18 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Also make ':' without anything else to mean "there is no pathspec". ÂThis
> would allow differences between "git log" and "git log ." run from the top
> level of the working tree (the latter simplifies no-op commits away from
> the history) to be expressed from a subdirectory by saying "git log :".

The intention is good, but reality may need more work. I assume that
"git add -u :" is equivalent to "git add -u" (or "git add -u ." to be
precise). Unfortunately, cmd_add() checks argc for no arguments to
turn "add -u <nothing>" to "add -u .", not the result from
get_pathspec(). It can be fixed. Just heads up as there can be similar
traps elsewhere.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]