On Thu, Apr 7, 2011 at 3:43 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Speaking of that logic, I've been wondering for about a year and a half if
> this "if (permille)" exclusion was intentional:
>
> If the user sets dir->percent to zero, with an expectation that it will
> disable all filtering, shouldn't we show everything?
Hmm. My gut feel is that you still don't want to see directories with
no changes. In fact, doesn't the whole "avoid even diffing identical
directories with the same SHA1" logic end up meaning that even if you
were to disable filtering, you'd _still_ not show the 0% case?
But hey, I dunno. If you want the semantics to be "not identical, but
not damaged enough to be even 0.1%, so show it", I don't think that
would be _wrong_ per se. I just don't think our current "ignore 0.0%
files" is wrong either ;)
Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html