2011/4/6 Junio C Hamano <gitster@xxxxxxxxx>: > Â* I was looking at the codepaths that would need to be touched in order > Â to properly support the "magic pathspec" we have been discussing, and > Â am leaning to conclude that all the users of get_pathspec() need to be > Â rewritten to throw the remainder of argv[] at a function that fills a > Â struct pathspec (in other words, a combination of get_pathspec() and > Â init_pathspec()). ÂMichael's "alternative approach to grep --full-tree" > Â was operating at the get_pathspec() level, but that function is an > Â interface to return an array of plain-vanilla strings only, and there > Â is no place to hook richer per-item information on the elements. ÂWe > Â would need "struct pathspec" in the function where we parse the argv[] > Â and combine its elements with prefix. I have started working on the conversion, but it may take a while because in many places pathspec is still assumed a prefix (and handled separately, which is not good for negative pathspec). Fundamental support for magic pathspec and "top dir" notation probably do not need get_pathspec() converted to struct pathspec. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html