Re: [PATCH v2 1/3] blame: add --abbrev command line option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 5, 2011 at 11:20 PM, Namhyung Kim <namhyung@xxxxxxxxx> wrote:
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> ---
> Âbuiltin/blame.c | Â Â4 +++-
> Â1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index f6b03f7..253b480 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -41,6 +41,7 @@ static int reverse;
> Âstatic int blank_boundary;
> Âstatic int incremental;
> Âstatic int xdl_opts;
> +static int abbrev = 8;
>
> Âstatic enum date_mode blame_date_mode = DATE_ISO8601;
> Âstatic size_t blame_date_width;
> @@ -1670,7 +1671,7 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
> Â Â Â Âcp = nth_line(sb, ent->lno);
> Â Â Â Âfor (cnt = 0; cnt < ent->num_lines; cnt++) {
> Â Â Â Â Â Â Â Âchar ch;
> - Â Â Â Â Â Â Â int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : 8;
> + Â Â Â Â Â Â Â int length = (opt & OUTPUT_LONG_OBJECT_NAME) ? 40 : abbrev;

Should this 40 be a constant?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]