On Mon, Apr 04, 2011 at 10:14:11PM -0400, Martin von Zweigbergk wrote: > This series fixes a few different bugs in gitk related to its working > directory. > > I started working on patch 1, which fixes "Highlight this only/too" > when gitk is started in a subdirectory. This problem has bothered me > for a long time, but I had heard that the Tcl code in gitk was hard to > maintain, so I didn't have a look at it until now. I have to say that > it was a lot easier to follow the code than I had feared. > > While testing that the fix in patch 1 worked, I found that gitk does > not work very well when the work tree is not at ".git/..", so most of > the other patches try to improve that situation. > > I think I have tested most combinations of setups (top-level dir, > subdir, separate work tree, bare repo, .git) and operations (highlight > file, blame, external diff, show origin of line). > This is something which anoyed me a long time. I even tried to fix it [1], but with my limited Tcl knowledge I failed misserably. Your patch series seems to fix all the problems I was having. Nice job! -Peter [1]: http://article.gmane.org/gmane.comp.version-control.git/120391 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html