"Alejandro R. SedeÃo" <asedeno@xxxxxxx> wrote:
> From: James Y Knight <jknight@xxxxxxxxxxxxxxx>
>
> This is necessary if you want to be able to commit to multiple branches.
I'm not sure I understand the need for this patch, see below.
> @@ -523,12 +523,14 @@ sub cmd_dcommit {
> }
>
> if (defined $_commit_url) {
> - $url = $_commit_url;
> + $url = $_commit_url . (length $gs->{path} ? '/' . $gs->{path} : '');
$_commit_url is a user-specified parameter from the --commit-url switch.
If they want to override it it's the user's perogative. It's not the
default and not commonly used.
> } else {
> $url = eval { command_oneline('config', '--get',
> "svn-remote.$gs->{repo_id}.commiturl") };
> if (!$url) {
> $url = $gs->full_url
If unspecified, we always fall back to the gs->full_url case anyways
which just duplicates the logic you've added. Again, commitUrl usually
does not need to be specified since it is autodetected.
> + } else {
> + $url = $url . (length $gs->{path} ? '/' . $gs->{path} : '');
> }
> }
--
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html