Stephen Boyd <bebarino@xxxxxxxxx> writes: > * load_file() returns a void pointer but is using 0 for the return > value > > * builtin/receive-pack.c forgot to include builtin.h > > * packet_trace_prefix can be marked static > > * ll_merge takes a pointer for its last argument, not an int > > * crc32 expects a pointer as the second argument but Z_NULL is defined > to be 0 (see 38f4d13 sparse fix: Using plain integer as NULL pointer, > 2006-11-18 for more info) I think these were originally coded this way to match the way the upstream zlib.h from which we use the function expects us to. But I tend to agree that we should ignore Z_NULL and use NULL throughout the system. The patch looked fine. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html