Re: [PATCH 5/4] run-command: implement abort_async for pthreads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 1, 2011 at 10:05 PM, Jeff King <peff@xxxxxxxx> wrote:
> On Fri, Apr 01, 2011 at 09:57:14PM +0200, Erik Faye-Lund wrote:
>
>> > But this does not help the case at hand in any way. How would you interrupt a
>> > thread that is blocked in ReadFile()? The point of pthread_cancel() is that
>> > it interrupts blocked system calls
>>
>> There is no mention of such a guarantee in POSIX (section 2.9.5 Thread
>> Cancellation), so relying on that is undefined behavior.
>
> Eh? My pthreads(7) says that read() is required to be a cancellation
> point acrroding to POSIX. I didn't dig up the actual reference in the
> standard, though.

I don't understand where the implementor would get that from after
reading through it, but if there's something I've missed we can fix it
by replacing my pthread_cancel with this, no?

static inline int pthread_cancel(pthread_t thread)
{
	SetEvent(thread.cancel_event);
	CancelSynchronousIo(thread.handle);
}
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]