On Fri, Apr 1, 2011 at 15:37, Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> wrote: > How about simply > > if (!dir) > Â Â Â Âreturn rmdir(path->buf); > > like we do later on in that function? > I'm used to try to keep the returned value of a function I modify, and I'm also used to not trust the return values of the functions I don't control. That's to my defense. But you're unquestionably right. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html