When we ask to finish_async, we should be quiet about things like signal death in the async process, for two reasons: 1. This better matches what happens on the Windows side, where threads are used (and what will eventually happen when pthreads are used on unix). 2. We pass along the error code to the caller, who needs to check and produce an error message anyway for the case of a non-zero exit code. Signed-off-by: Jeff King <peff@xxxxxxxx> --- run-command.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/run-command.c b/run-command.c index 0d5626a..258c880 100644 --- a/run-command.c +++ b/run-command.c @@ -427,7 +427,7 @@ error: int finish_async(struct async *async) { #ifndef WIN32 - int ret = wait_or_whine(async->pid, "child process", 0); + int ret = wait_or_whine(async->pid, "child process", 1); #else DWORD ret = 0; if (WaitForSingleObject(async->tid, INFINITE) != WAIT_OBJECT_0) -- 1.7.4.13.g8566c -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html