The variables dir and path are always allocated on the stack so it's always safe to free them. This memory would be freed by _exit, but it's good form to free memory you've allocated. Signed-off-by: Carlos MartÃn Nieto <cmn@xxxxxxxx> --- This is a split-up version of an earlier patch. It's not a big deal, but I had it in a local branch and I though I'd try to have it merged upstream. builtin/clone.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index 2ee1fa9..fe0408c 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -665,6 +665,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix) err = run_command_v_opt(argv_submodule, RUN_GIT_CMD); } + free(dir); + free(path); strbuf_release(&reflog_msg); strbuf_release(&branch_top); strbuf_release(&key); -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html