On Thu, Mar 31, 2011 at 12:36:15PM +0300, Alexandru Sutii wrote: > I began implementing the minimal git client[1]. I have implemented the > "git-mktag" command. For this I have modified the "mktag.c" file from > the "builtin" directory in order to make it run with libgit2. Basically the > input file verification code is the same with the original one. I have just > extracted the sha1, the object type, the tag name, the tagger, the > comment and created a tag with git_tag_create. Hi there, I started git2 client a couple of days ago and implemented a rough version of rev-list.c (which shows rev-list of HEAD. It is here: https://github.com/Motiejus/git2/ Vincent van Ravesteijn forked and made some modifications: https://github.com/vfr-nl/git2/ Thanks to him for CMakeLists.txt. > > I have also used the original "usage.c" and "git-compat-util.h" for > error handling. Is there a problem if the git2 client will reuse > non-gitcore code, such as string parsing code, parameter parsing code, > etc? I think this is what it has to be like. Provided it adds no requirements and license issues. > > Can someone look on my code and give me some feedback? You have done a good job in creating handlers and hooking up the repository. Thank you. > > Just before ending the implementation of the mktag command I have > started thinking that maybe there was no need to reimplement this > command, as it can be considered that libgit2 already has this > feature. Even if it is so I am not sorry I did this, because by > reimplementig it I had the chance to get used with git code and with > libgit2 API. Don't know about the actual tag implementation, but in any case, the wrapper (glue) code around the tag very helpful. Best, Motiejus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html