Ramkumar Ramachandra wrote: > [Subject: strbuf: Introduce strbuf_fwrite corresponding to strbuf_fread] > > Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx> And why? FWIW strbuf_fread takes care of (1) setting the size of sb to accomodate the input, (2) starting reading at the end of the current strbuf, and (3) freeing the buffer if nothing could be read, so symmetry doesn't seem like a strong justification. Which is not to say this is a bad change. Just that it's hard to see how it lives up to its goals without knowing what those goals are. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html