Michael Witten <mfwitten@xxxxxxxxx> writes:
> diff --git a/sha1_file.c b/sha1_file.c
> index e55a496..a6c1f1f 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -390,11 +390,11 @@ void add_to_alternates_file(const char *reference)
>
> void foreach_alt_odb(alt_odb_fn fn)
> {
> - struct alternate_object_database *ent;
> + struct alternate_object_database *d;
>
> prepare_alt_odb();
> - for (ent = alt_odb_list; ent; ent = ent->next)
> + for (d = alt_odb_list; d; d = d->next)
> - if (fn(ent))
> + if (fn(d))
I see this as a naming regression; that pointer variable points at an
entry in a list, and the callback is very well aware of that too (so the
s/e/d/g in an earlier hunk also is a naming regression).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html