Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Maxin john <maxin@xxxxxxxxxxxxxxx> writes:

> So, I have modified the patch by incorporating most of the nice suggestions.

I'd just replace /bin/bash with /bin/sh without any other fuss, perhaps
except for the typofix in the comment, and be done with the topic.

The script in the current version may look ugly to my eyes and others, but
there is nothing _wrong_ in it per-se.  Rewriting them in different styles
is not necessarily improvement, and this is only a contrib/ material after
all.

Thanks, I'll apply the early hunks from you.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]