On Tue, Mar 29, 2011 at 10:35:47AM -0400, Jeff King wrote: > On Tue, Mar 29, 2011 at 12:05:09PM +0200, Michael J Gruber wrote: > > > - if (!prefixcmp(arg+13, "refs/")) > > + if (!prefixcmp(arg+offset, "refs/")) > > /* happy */; > > - else if (!prefixcmp(arg+13, "notes/")) > > + else if (!prefixcmp(arg+offset, "notes/")) > > strbuf_addstr(&buf, "refs/"); > > else > > strbuf_addstr(&buf, "refs/notes/"); > > - strbuf_addstr(&buf, arg+13); > > + strbuf_addstr(&buf, arg+offset); > > string_list_append(revs->notes_opt.extra_notes_refs, > > strbuf_detach(&buf, NULL)); > > This issue is not introduced by your patch, but maybe it is a good > opportunity to refactor this to use expand_notes_ref from notes.c? Oops, I just realized this is in builtin/notes.c in master. I had already written a patch for another topic that made it globally accessible. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html