Hi,
> It is better to explain the patch as
>
> Subject: contrib/thunderbird-patch-inline: do not require /bin/bash to run
Yes. I do agree with you. I should have chosen a better Subject line
for this patch. Should I resend this patch with this modified Subject
line ?
Thanks and Regards,
Maxin B. John
On Tue, Mar 29, 2011 at 4:01 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Maxin john <maxin@xxxxxxxxxxxxxxx> writes:
>
>> Remove "bashism" and minor corrections for
>> contrib/thunderbird-patch-inline/appp.sh
>
> The script seems to only use standard POSIX shell features and nothing
> particularly bash specific nor outside POSIX in general that we exclude
> from our coding standards (e.g. "local", use of "function" noiseword,
> substring expansion ${parmeter:offset:length}).
>
> It is better to explain the patch as
>
> Subject: contrib/thunderbird-patch-inline: do not require /bin/bash to run
>
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html