Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Jens Lehmann wrote: > >> - GIT_SKIP_TESTS >> - GIT_TEST* >> - GIT_PROVE_OPTS >> >> Let's fix that by adding them to the exception list. >> >> Signed-off-by: Jens Lehmann <Jens.Lehmann@xxxxxx> > > Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > > It misses a few, though: > > - GIT_REMOTE_SVN_TEST_BIG_FILES > - GIT_NOTES_TIMING_TESTS > - GIT_PATCHID_TIMING_TESTS > - GIT_VALGRIND_OPTIONS > > If we were starting over I suppose those would all be GIT_TEST* but > there's something to be said for muscle memory. I don't think muscle memory matters as much in this case as the usual end-user facing interfaces. These are only for people who build and test git, not for our end users. I think it is Ok to do this (yes I am trying to avoid doing this myself, as I am a bit behind and also am lazy) just as a single patch to rename the environment variables, and filter them with a single GIT_TEST_* pattern at the same time. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html