On Sat, Mar 26, 2011 at 19:31, Jeff King <peff@xxxxxxxx> wrote: > On Sat, Mar 26, 2011 at 07:21:26PM +0100, Alex Riesen wrote: > >> > No, it's totally broken. $(pwd)/$test is nonsensical. The code right >> > above your change guarantees that $test is an absolute path, either >> > because the user gave us an absolute $root or because it has been >> > prepended with $TEST_DIRECTORY (which itself comes from $(pwd)). >> >> I see. I mistook "$root" for the root of a filesystem, not the variable in >> test-lib.sh. How about this, than? > > Oops, when I said "$test" I meant to say $TRASH_DIRECTORY. That is, > $TRASH_DIRECTORY is always the absolute path to the trash. > >> +HOME="$(pwd)/$test" >> +test -n "$root" && HOME="$test" >> +export HOME > > So you can simplify this to just: > > HOME=$TRASH_DIRECTORY > Aah... I should have actually looked at the "case" which sets TRASH_DIRECTORY! Will resend in a moment. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html