Joe Ratterman <jratt0@xxxxxxxxx> writes: > grep.extended-regexp: Enabling this boolean option has the same effect > as adding "-E" to all "git grep " instantiations. This can be > disabled by specifying "--no-extended-regexp" on a particular call. > > grep.line-numbers: Enabling this boolean option has the same effect as > adding "-n" to all "git grep " instantiations. > > Signed-off-by: Joe Ratterman <jratt0@xxxxxxxxx> Thanks. Things to consider: - Apply this patch on top of "master",run "git shortlog v1.7.4..HEAD", store the output somewhere, and imagine reading that 2 months from now. Does a single line in the output about this patch sufficiently tell you what it was about? - Configuration variables are spelled without hyphens between words (you can see "gui.commitmsgwidth" in the context of the patch you sent and notice that it is not "gui.commit-msg-width"). - This will break scripts people have written, knowing that they can rely on "grep" they wrote without giving "-E" from their command line will use BRE, and force them to update the script with --no-extended-regexp for no good reason. Worse yet, there isn't even --no-line-numbers supported to defeat grep.linenumbers configuration to protect such scripts. I understand that some people would feel that the convenience would outweigh the risk of script breakage in this particular case, and I am sympathetic to the cause, but I still have to point it out. Is there anything we can do to mitigate the risk somehow? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html