Re: Relative ls-files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

> This read_tree_recursive() affects 'archive' and 'checkout -- paths'
> (ie. no wildcard awareness). I will probably move match_tree_entry()
> to ls-tree.c to preserve its behavior, then change
> read_tree_recursive() to use tree_entry_interesting().

[jc: culled people other than those in the "magic pathspec" discussion
from CC list]

Wouldn't it be more sensible to add a bit ("is this a glob or are we
expected to match it literally") to each element in the pathspec array,
and pass a pathspec whose elements are all marked as "literal" down from
ls-tree?

The internal matcher (and traversal optimizer) would need to become aware
of "not a glob" match (and possibly different kinds of matches like "**/"
support) sooner or later, and when that happens you would need something
like the above on the caller side in ls-tree.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]