On 23 March 2011 16:52, Stephen Hemminger <shemminger@xxxxxxxxxx> wrote: > 1. The following needs to be fixed: > > $ git svn clone > Use of uninitialized value $_[0] in substitution (s///) at /usr/share/perl/5.10.1/File/Basename.pm line 341. > fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line 403 While noisy and ugly, uninitialized warnings are usually pretty harmless... > 2. The git-svn perl script does not follow Perl Best Practices. > If you run the perlcritic script on it, all the following warnings/errors > are generated: Some of these are undoubtedly valid complaints, but the so called best practices that the perl critic policies implement are, in my opinion, not widely accepted as such by the perl community. At least not all of them. I wouldn't go following them blindly - especially in working production code... /Lasse -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html