Jeff King <peff@xxxxxxxx> writes: >> Junio, please let me/us know whether sending an amended series in this way >> (which I've seen before) is actually convenient for you or not. !squash >> commits require a message edit, for example. OTOH, I don't know any (other?) >> good inter diff solution. > > As a reviewer, I find it is usually most convenient to just have the > submitter do the squash, and then write below the "---" (or in a cover > letter like this) a brief explanation of the differences. > > Yeah, I end up reading the whole patch again, including bits I already > read, but that is probably a good thing. A good patch is hopefully not > too long, and it is easier (to me, anyway) to review it as a whole and > not as an interdiff. Yes. And that would also make it easier for people who didn't read the earlier round to double check. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html