Re: Histogram diff, libgit2 enhancement, libgit2 => git merge (GSOC)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Histogram diff:
There is no mentor mentioned in [1]. Does it mean that there is no person
..

As the original author of HistogramDiff in JGit, and a contributor to
C Git... I'm probably the best person to mentor this task. I'm really
busy, so I didn't sign up to mentor anything else this year, but I
think I would make time for this project.

Thanks for your answer and for your ability to be a mentor of this task.

There is a goal "Get this feature merged to the upstream git." -- but I have
one theoretical question -- what if the benchmarking/study of histogram diff
leads to conclusion that this algorithm will not be useful for upstream?

Then the project doesn't merge. :-)

Does it mean "fail" in terms of GSOC? I have to think about it even if it
looks that there should be speedup quite obvious. I don't want to fail
a priory :).

I don't think so

I think the success of this project is if the code is of the quality
that upstream would accept it, and if the final analysis data makes it
clear whether or not its worth including. Its probably not worth
including if its the same speed as the current Myers diff
implementation from libxdiff or slower. But if its 2x faster, its
probably worth merging. If the code quality is acceptable to the
upstream maintainers.

I wanted to know exactly this kind of information. Of course
I don't want to make a code of unacceptable quality from any perspective.

And I think that you probably don't expect histogram diff to be significantly
faster in general :)

Thanks again - it is good to know that you as author of histogram diff are
here. And sorry for my latency ..
[ot] this is because of hectic school schedule now - which is actually not
good :( I need to study git source very deeply _NOW_ (I wanted to reply
earlier but..) [/ot]

Thanks to Junio C Hamano with almost the same answer here:
http://thread.gmane.org/gmane.comp.version-control.git/169498/focus=169516

Pavel

[1] https://git.wiki.kernel.org/index.php/SoC2011Ideas
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]