[WIP PATCH 02/10] Reminder to fix o->call_depth handling in conflict_rename_rename_1to2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



---
 merge-recursive.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/merge-recursive.c b/merge-recursive.c
index 6dc74dc..8d28a54 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -908,6 +908,10 @@ static void conflict_rename_rename_1to2(struct merge_options *o,
 		       ren2_dst, branch1, dst_name2);
 	}
 	if (o->call_depth) {
+		/*
+		 * FIXME: This is bogus.  dst_nameX are not in cache in
+		 * case of D/F conflict.
+		 */
 		remove_file_from_cache(dst_name1);
 		remove_file_from_cache(dst_name2);
 		/*
-- 
1.7.4

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]