Re: [PATCH] merge-recursive: tweak magic band-aid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Mar 18, 2011 at 12:07 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Running checks against working tree (e.g. lstat()) and causing
> changes to working tree (e.g. unlink()) while building a virtual
> ancestor merge does not make any sense. Avoid doing so.
>
> This is not a real fix; it is another magic band-aid on top of
> another band-aid we placed earlier.
>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>

Sorry for not responding sooner; thanks for fixing this up, though.
Also, I have to apologize for having left a bunch of changes on my
harddrive for several months; one of those changes includes the first
half of your patch (which I should have remembered and not made the
problem worse with my more recent patch submission.)  I just never got
around to cleaning up those changes and getting them submitted.  Maybe
I should just send what I do have for now, and then send the cleaned
up version when I get a good chunk of time in another month or two.

> Â merge-recursive is riddled with places that touch/inspect working tree
> Â when it shouldn't, and it is beyond salvage without a major refactoring
> Â in its current shape, so this magic band-aid should do for now.

Yeah, I agree this needs to be fixed up.  If no one else takes a look,
I'll try to when I get back to my other changes.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]