Ben Walton <bwalton@xxxxxxxxxxxxxxxxxx> writes: > The test setup in t8006-blame-textconv.sh used ln -sf to overwrite an > existing symlink. Unfortunately, both /usr/bin/ln and > /usr/xpg4/bin/ln on solaris 9 don't properly handle -f when -s is > used. Thanks for reporting. I recall "ln -s -f" traditionally has been a pain point not just on Solaris. > This caused the test setup to fail which caused subsequent > checks to also fail. > > This patch uses changes the first check in the test to rm the symlink > and then create the new symlink using only -s. s/uses //; I think. It is curious why "rm symlink.bin" is not inside the test-have-prereq part, iow, immediately before the problematic "ln -s", where it logically belongs to, though. What does the updated code do on systems without symbolic link support? > The upstream Solaris bug (fixed in 10, but not 9) is documented here: > http://bugs.opensolaris.org/view_bug.do?bug_id=4372462 > > Signed-off-by: Ben Walton <bwalton@xxxxxxxxxxxxxxxxxx> > --- > t/t8006-blame-textconv.sh | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/t/t8006-blame-textconv.sh b/t/t8006-blame-textconv.sh > index ea64cd8..c5362d9 100755 > --- a/t/t8006-blame-textconv.sh > +++ b/t/t8006-blame-textconv.sh > @@ -24,8 +24,9 @@ test_expect_success 'setup ' ' > GIT_AUTHOR_NAME=Number1 git commit -a -m First --date="2010-01-01 18:00:00" && > echo "bin: test 1 version 2" >one.bin && > echo "bin: test number 2 version 2" >>two.bin && > + rm symlink.bin && > if test_have_prereq SYMLINKS; then > - ln -sf two.bin symlink.bin > + ln -s two.bin symlink.bin > fi && > GIT_AUTHOR_NAME=Number2 git commit -a -m Second --date="2010-01-01 20:00:00" > ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html