On Sun, 20 Mar 2011, Kevin Cernekee wrote:
> From: Jakub Narebski <jnareb@xxxxxxxxx>
>
> Make the timezone parameter mandatory. This ensures that the *_local
> fields are always populated with accurate information.
That is better commit message that what I came with.
> Also, delete an unnecessary call to format_date().
>
> Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
> Signed-off-by: Kevin Cernekee <cernekee@xxxxxxxxx>
> ---
>
> v2: Fix typos. Remove unnecessary call.
Thanks.
> Remove default "-0000" tz value.
Hmmm... I wonder if default value for timezone might have been intended
to handle case of malformed date, without timezone.
This fragment
my $epoch = shift;
my $tz = shift || "-0000";
is from very beginnings of gitweb... and "v042" is a bit uninformative
as a commit message. 991910a (v042, 2005-08-07).
> Rebase on top of my patch 3/3 (as applying -1/3 then 1/3 would create a
> merge conflict).
You are right, that is better solution.
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html