On Fri, Mar 18, 2011 at 10:46 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> Kevin, how about something like this instead? ÂThis preserves _intent_
> for why there is local time beside GMT time when 'localtime' is disabled
> better, I think.
Fine with me. I had to dig around for a while before I could find an
"atnight" commit, so I don't think this is something that is likely to
occur often in my environment. But I can see how it would be useful
to preserve the existing functionality.
I applied your patch and verified it in both localtime=0 and
localtime=1 cases. So:
Tested-by: Kevin Cernekee <cernekee@xxxxxxxxx>
> Junio and Kevin, I am not sure if authorship should remain with Kevin,
> or should it revert to me; the solution is quite different.
I would suggest reverting it to you.
> @@ -4003,15 +4003,23 @@ sub git_print_authorship_rows {
> Â Â Â Â Â Â Â Âmy %wd = parse_date($co->{"${who}_epoch"}, $co->{"${who}_tz"});
> Â Â Â Â Â Â Â Âprint "<tr><td>$who</td><td>" .
> Â Â Â Â Â Â Â Â Â Â Âformat_search_author($co->{"${who}_name"}, $who,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âesc_html($co->{"${who}_name"})) . " " .
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âesc_html($co->{"${who}_name"})) . " " .
> Â Â Â Â Â Â Â Â Â Â Âformat_search_author($co->{"${who}_email"}, $who,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âesc_html("<" . $co->{"${who}_email"} . ">")) .
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âesc_html("<" . $co->{"${who}_email"} . ">")) .
FWIW, this does create a few >80 character lines. But
CodingGuidelines doesn't say whether that limit applies to Perl
scripts or just C.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html