Carlos MartÃn Nieto <cmn@xxxxxxxx> writes: > + ret = snprintf(buf, sizeof(buf), "%s/%s", prefix, path); > + if (ret >= sizeof(buf)) > + die("system path too long for %s", path); > + else if (ret < 0) > + die_errno("encoding error"); POSIX says snprintf() should set errno in this case, and your use of die_errno() would show that information, but what is "encoding error"? Just being curious, as I suspect that "snprintf() returned an error" may be more appropriate, if the answer is "I don't know what kind of error it is, but snprintf() found something faulty while encoding so I chose to call it encoding error". By the way, thanks for checking all the callers. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html