Re: [PATCH 1/2] fetch-pack: Finish negotation if remote replies "ACK %s ready"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 17, 2011 at 03:15:12AM -0400, Jeff King wrote:

> > Assuming the client is only following the remote (and does not make
> > its own local commits), the client needs 11 rounds to spin through
> > the entire list of tags (32 commits per round, ceil(339/32) == 11).
> > Unfortunately the server knows on the first "have %s" line that
> > it can produce a good pack, and does not need to see the remaining
> > 320 tags in the other 10 rounds.
> 
> Does this optimization help in that case? From looking at the code, it
> seems that we offer "ACK %s ready" only in the case that the client
> has something we do not. I.e., they _are_ building local commits on top.

OK, never mind, I just read your 2/2. ;)

Sorry for the noise.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]