On Tue, Mar 15, 2011 at 01:56:43AM -0500, Jonathan Nieder wrote: > Set GIT_ATTR_NOGLOBAL and GIT_ATTR_NOSYSTEM in test-lib to make > tests more reliable in two ways: > > - an invalid GIT_ATTR_NOGLOBAL or GIT_ATTR_NOSYSTEM setting > should not cause tests to fail with > > fatal: bad config value for 'GIT_ATTR_NOGLOBAL' > > - /etc/gitattributes should not change the outcome of tests. We already munge $HOME, as you note in 1/3, I don't know that there is much point in setting GIT_ATTR_NOGLOBAL. The alternative would be to drop your 1/3 and unset GIT_ATTR_NOGLOBAL in test-lib.sh. I don't care much either way. Having it set prevents others tests from accidentally triggering global attributes (since we have the odd case of $HOME and the repo in the same directory). But IIRC, they'd have to set core.attributesfile anyway, so that is not likely to happen. And what you're doing at least matches what GIT_CONFIG_* does (I think GIT_CONFIG_NOGLOBAL is also redundant in the tests at this point). So I'm fine with either strategy. But definitely it should be protected, so thanks for looking into it. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html