Re: Fwd: [PATCH 2/2] pretty.c: allow date formats in user format strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 09, 2011 at 01:06:17PM -0800, Junio C Hamano wrote:

> > Agreed. And I think it is possible to do it in a backwards-compatible
> > way; support %(longname:options) for everything, and keep short-hands
> > like %h and %ad for existing elements without options.
> 
> Yes, I think %( is not taken in the pretty-format language, so we should
> be able to do this.
> 
> I wanted to take your earlier "'%ad' or '%ad(format)'" patch but refrained
> from doing so.  The above line of reasoning is much better for the long
> term health of the project.

OK. Do you want me to throw away the %ad(format) patch for now, then, in
favor of building it on top of a more sane syntax?

I had originally planned to do %ad(format) for now, and then worry about
syntax later. Since we already have a variety of of other placeholders
with similar syntax (e.g., %w(), %C()). But I don't care too much either
way; it is not a feature I personally wanted, so delay doesn't bother
me. Dietmar (the original requestor) may feel differently, of course. :)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]