Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > To avoid having to worry about a conflicting ngettext symbol when > libintl is part of libc, also rename the no-op ngettext stub to > git_ngettext and make ngettext a macro referring to it. This is > probably never necessary (because git's ngettext is declared "static > inline") but it buys peace of mind. Hmph. An obviously safer alternative would be to use git_ngettext() in our source all over the place, and it would by even more peace of mind but that is even longer. > This change does not protect against conflicts due to a header > included _after_ git's i18n support (e.g., pthread.h) being the first > to pull in libintl. We can deal with that separately if it happens. Also the same problem exists already for the _() macro. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html